docs: correct/add subgraph preamble comments (fixes #1194)
#1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mo-Gul
force-pushed
the
GraphsStandardCodeExamples
branch
from
ece8796
to
179110c
Compare
muzimuzhi
approved these changes
Oct 8, 2022
Signed-off-by: Stefan Pinnow <[email protected]>
Mo-Gul
force-pushed
the
GraphsStandardCodeExamples
branch
from
179110c
to
af40f01
Compare
|
sorry, missed one file ... |
hmenke
reviewed
Oct 9, 2022
| "]] | ||
| examples = { | ||
| { | ||
| options = [["preamble={\usetikzlibrary{graphs.standard,graphdrawing} \usegdlibrary{circular}}"]], |
There was a problem hiding this comment.
I'm not sure whether I merged the support for this new syntax yet. I have to check that before merging.
There was a problem hiding this comment.
Yes, you had. At least it seems to work in the currently available first example of
pgf/tex/generic/pgf/graphdrawing/lua/pgf/gd/force/ControlElectric.lua
Lines 42 to 60 in 0280303
which shows as
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead:
Remaining instances are
pgf/tex/generic/pgf/graphdrawing/lua/pgf/gd/doc/ogdf/energybased/FMMMLayout.lua
Lines 108 to 123 in 0280303
but since these are not part of the current manual and I couldn't make this part of the manual run, I decided not to fix them.